Bogus config "channel: manual"

[jrieken]

re #12817

We now "update.channel": "manual" which is so weird. What does "channel" and "manual" mean in this context? It hardly makes sense and I think its time to rename that setting

[joaomoreno]

It's always hard to rename settings... so I don't think I'll do that... 😢

But we can definitely improve the documentation:

[jrieken]

It's always hard to rename settings...

Are you kidding? It's super easy:

1. remove the schema for the old setting
2. add new setting that defaults to the old setting

I am actually surprised that we don't have some automatic helper util for this

[joaomoreno]

Hm... I never did that before, smart. 🤓

Any suggestions? Just update? Or product.update? workbench.update?

[joaomoreno]

Maybe update.type, since there are other update.* settings. Or update.frequency. update.trigger.

Or update.enabled? With values true, false, manual.

@jrieken What do you think?

[jrieken]

Yeah, dislike the workbench prefix. It always smells like our internal names leak to customers. 👍 for update.enabled, just update, or update.mode. Somehow, enabled makes me expect true/false.

[joaomoreno]

@jrieken Unfortunately we can't use update, since it's a prefix for other settings. I'll use update.mode and rename values to disabled, automatic (default), manual.

[joaomoreno]

@jrieken Actually, this is not so trivial, because I am not able to distinguish the users who have manually set update.mode to the default setting or haven't set it at all... there's no such feature in the configuration service...

@bpasero Any recommendations on setting name migration?