Installing extension from extension page "Install" button keeps the notification baloon in bottom right

[vfonic]

Issue Type: Bug

I noticed when I install extension by clicking on the green "Install" button from within the VScode extension page, as opposed to the "Would you like to install..." notification/chat bubble in the lower right corner of the editor, the chat bubble stays there, asking me if I want to install the extension I just installed.

Would be great if the state was in sync and the bubble would be dismissed when I installed the extension, no matter how.

Screenshot after installation

VS Code version: Code 1.33.1 (51b0b28, 2019-04-11T08:22:55.268Z)
OS version: Darwin x64 18.5.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (0.79GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (19)

Extension	Author (truncated)	Version
project-manager	ale	10.5.1
solargraph	cas	0.19.6
bracket-pair-colorizer	Coe	1.0.61
vscode-eslint	dba	1.8.2
es7-react-js-snippets	dsz	2.2.2
gitlens	eam	9.7.1
prettier-vscode	esb	1.9.0
rails-snippets	Hri	1.0.8
rest-client	hum	0.21.2
vscode-codemetrics	kis	1.18.0
vscode-language-babel	mgm	0.0.22
ruby-rubocop	mis	0.8.0
sublime-keybindings	ms-	4.0.0
debugger-for-chrome	msj	4.11.3
JavaScriptSnippets	nat	0.2.0
ruby	reb	0.22.3
code-settings-sync	Sha	3.2.9
change-case	wma	1.0.0
JavaScriptSnippets	xab	1.7.2

[skprabhanjan]

@sandy081 , I would like to try this , Some starter and code pointers would be helpful :)

[sandy081]

It depends on how @vfonic got this notification. @vfonic can you please let us know how you got this?

[vfonic]

It shouldn't depend on that. I got it by clicking install button in VS Code Extension Marketplace website, in the browser.

…

On Thu, May 16, 2019, 01:15 Sandeep Somavarapu ***@***.***> wrote: It depends on how @vfonic <https://github.com/vfonic> got this notification. @vfonic <https://github.com/vfonic> can you please let us know how you got this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#73341?email_source=notifications&email_token=AAAQO3JVP64PZG4N26BCTFTPVRHNHA5CNFSM4HK67US2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVPP4KA#issuecomment-492764712>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAQO3OZNBWANLVHJ7DSLYLPVRHNHANCNFSM4HK67USQ> .

[sandy081]

@skprabhanjan This notification comes from here - https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/contrib/extensions/node/extensionsWorkbenchService.ts#L1083

[skprabhanjan]

@sandy081 , I checked the code but just wanted to discuss on one thing .

Is that notification needed in the first place , clicking on install button on top will do the same job , Also removing that notification will keep the two scenarios consistent and same (Normally opening that extension page and opening the extension page from browser)
We can remove the notification prompt to fix the inconsistency .

[skprabhanjan]

@sandy081 , were you able to look into this ?
I can remove the notification bubble and send a PR, please confirm :)

[sandy081]

@skprabhanjan Yeah it look unnecessary for me. Please remove it.