process object used in browser/terminalTaskSystem

[Tyriar]

vscode/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts

Lines 1378 to 1387 in 7152aa5

	cwd = process.cwd();
	}
	const dir = path.dirname(command);
	if (dir !== '.') {
	// We have a directory and the directory is relative (see above). Make the path absolute
	// to the current working directory.
	return path.join(cwd, command);
	}
	if (paths === undefined && Types.isString(process.env.PATH)) {
	paths = process.env.PATH.split(path.delimiter);

I'm planning on copying this function to the terminal contrib for #76349, so maybe tasks can use that?

[Tyriar]

@alexr00 FYI this now exists in terminal/node:

vscode/src/vs/workbench/contrib/terminal/node/terminalEnvironment.ts

Line 82 in a570522

export async function findExecutable(command: string, cwd?: string, paths?: string[]): Promise<string | undefined> {

Note that it's a little different the the method in tasks, the terminal one will ensure the path exists and return undefined if not.

[alexr00]

Since it's in node I can't use it in terminalTaskSystem. The bit of tasks code that calls findExecutable will never run where there isn't node. It should still be fixed though.

[Tyriar]

@alexr00 feel free to pull it into common if you need to, adding an optional env arg and passing the process deps in via findExecutable in node/terminalEnvironment.ts

[alexr00]

Fixed by 4acba1a