Updating breakpoint from debug adapter does not work if another session is focused

[dgozman]

When implementing Debug Adapter Protocol, I sometimes issue breakpoints event where breakpoints change the verified status from false to true. If that happens while another debugging session is current (focused), the update is ignored.

I think the problem is in this line. Here idFromAdapter depends on currently focused debugging session, which may or may not be the one receiving the event.

Steps to reproduce:

• Use this modified version of vscode-mock-debug.
• Run the mock debug extension on testWorkspace folder included in the branch above.
• Set breakpoint in the session2.md file on the line with "lazy".
• Launch "Bug" configuration.
• Two scenarios
  • If you select "Session2" during first 5 seconds, breakpoint on the "lazy" line will be verified after 5 seconds (Session2 will emit "breakpoint changed" DAP event).
  • If you don't select "Session2" during first 5 seconds (e.g. do nothing, Session1 will be focused by default), the breakpoint will not be verified, and switching between sessions afterwards does not help.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Test: data breakpoints (#79799)
• Allow for a Breakpoint to be Enabled when breakpoints are deactivated (#65394)
• persisted data breakpoints are not registered (#79895)
• Node debugging: Breakpoints are verified (#67644)
• Debug adapter protocol: Allow for breakpoints to resolve to multiple locations (#59839)

[isidorn]

@dgozman your analysis is correct. That line is the issue and should look at the id from the recieving session, not from the focussed session.
This is not a regression, thus I plan to fix this next milestone.
Also I am open to a PR which fixes this since you already nicely found the root cause.

Proposed fix: idFromAdapter should be a real method and not a getter. This method needs to be passed in a sessionId so it is not dependent on the focused session.