debug UI doesn't cleanup spinners on debug session end

[weinand]

• modify mock-debug so that the response of the variables request is delayed:

   		setTimeout(() => {
   			this.sendResponse(response);
   		}, 1000 * 100);

• start debugging
• observe spinning in Variables view
• terminate debug session

Observe: spinning continues

[isidorn]

I will look into this while we add the cancelation support. It goes in the same direction.

[weinand]

Makes perfect sense. I found the error because I was adding cancelation support to mock debug ;-)

[isidorn]

The issue here was that debug adapters running in the EH were not calling cancel pending requests on stop session.
An additional issues was that we were accidently clearing pending requests before actually completing them.

Once I fixed this I found out that Mock debug does not handle very well the stiuation when I cancel a request and after that send a new one.
However I could not reproduce this issue with other adapters so I suspect this is something mock debug specific.

[weinand]

@isidorn good find with the clearing pending requests before actually completing them.

But you don't have to copy one map into another map by rehashing all the elements.

It is sufficient to just do this:

	const pending = this.pendingRequests;
	this.pendingRequests = new Map<number, (e: DebugProtocol.Response) => void>();

[isidorn]

Thanks for the snippet that makes sense. However in this particular case (after some code changes) I want to give 500 ms for the promise to finish on its own, thus it has to be in the this.pendingRequests and I can not clear the whole map right away.

[weinand]

I see. But why are you then copying the pending requests at all into the "pending" local variable?