Debug Console duplication

[vigneshshankar96]

When I press 'Start Debugging' for a Python script it opens a new Python Debug Console terminal. This is expected. But when I press the restart button for the same Python script, it opens a new Python Debug Console terminal occasionally. The previous console is not closed and populates the terminal drop-down. I have not tried the same with other languages.

[isidorn]

I believe this is being done from the python extension by sending a runInTerminal request which is handled here which at the end gets here
Assigning back to @weinand since he introduced that and might be better to check if we can reuse temrinals there. Feel free to assign back so I can investigate more.

[weinand]

Oh I see, the Python extension calls the Integrated Terminal "Python Debug Console" which is misleading.

[weinand]

@vigneshshankar96 VS Code tries to reuse an existing Integrated Terminal for a new debug session if nothing is running in that existing Integrated Terminal.
If something is running in the existing Integrated Terminal (e.g. the last debug target), VS Code creates a new session.

Could this explain the behavior you are seeing?

[int19h]

"Python Debug Console" is by analogy with Node, which uses "Node Debug Console" for integrated terminal.

Could it be that restart is asynchronous to such an extent that the program in the previous session has not exited before a new session is started, and the terminal is considered "in use"?

[maxgubler]

I've noticed this behavior on Windows using git bash as the integrated terminal, but attributed it to lack of support for git bash. What OS / terminal is this @vigneshshankar96 ?

[vigneshshankar96]

@weinand Not exactly
@maxgubler I am using Windows 10 with Command Prompt as my default terminal, with a Conda environment.

Here are the steps I followed to replicate the problem.

1. I am currently running a debug session on third terminal tab [3: Python Debug Console]
   

2. I click on Restart for the debug session. A new terminal is opened [4: Python Debug Console], and a new debug session is started
   

3. The previous debug session's terminal tab [3: Python Debug Console] is still open with the session closed as expected, but why did it open the new [4: Python Debug Console] terminal in the first place