Add terminal colors to Monokai Dimmed theme

[JanisGailis]

I'd like to suggest an improvement to the Monokai Dimmed theme.

Monokai Dimmed doesn't have terminal colors set, resulting in 'ugly looking' fancy terminal features, such as Powerline.

For a nice looking improvement, the terminal colors can be taken from the Monokai theme:

Before:

After:

I intend to open a Pull request shortly that realizes this suggestion.

[miguelsolorio]

👍 This looks much better, thanks for the PR!

Before

After

[JanisGailis]

@misolori Thanks for accepting the PR!

As a side note, I quickly looked at the other themes, and many of them haven't set any terminal colors, and even the ones that have them set usually haven't aligned ANSI black with the background, leading to weird-looking 'fancy shell features':

Then again, there are documented ways how to adjust the color palettes for a particular VSCode installation or workspace, and this is quite likely a bit of an edge case anyway.

Thanks for all the good work you guys have been doing!

[ejose19]

Is there an option to disable this? or if there's not what would be the values one would need to set on terminal.X to revert what the commit changed? I prefer the non washed terminal and noticed this changed on last update.

Edit: For anyone looking to use default terminal colors, add this to settings.json

"workbench.colorCustomizations": {
  "terminal.ansiBlack": "#000000",
  "terminal.ansiBlue": "#2472c8",
  "terminal.ansiBrightBlack": "#666666",
  "terminal.ansiBrightBlue": "#3b8eea",
  "terminal.ansiBrightCyan": "#29b8db",
  "terminal.ansiBrightGreen": "#23d18b",
  "terminal.ansiBrightMagenta": "#d670d6",
  "terminal.ansiBrightRed": "#f14c4c",
  "terminal.ansiBrightWhite": "#e5e5e5",
  "terminal.ansiBrightYellow": "#f5f543",
  "terminal.ansiCyan": "#11a8cd",
  "terminal.ansiGreen": "#0dbc79",
  "terminal.ansiMagenta": "#bc3fbc",
  "terminal.ansiRed": "#cd3131",
  "terminal.ansiWhite": "#e5e5e5",
  "terminal.ansiYellow": "#e5e510",
  "terminal.border": "#80808059",
  "terminal.foreground": "#cccccc",
  "terminal.selectionBackground": "#ffffff40"
}