Upgrade Playwright to v1.8.0. #115241
Merged
bpasero merged 2 commits intomicrosoft:masterfrom Feb 2, 2021
MarcoZehe:I115223
Merged
Upgrade Playwright to v1.8.0. #115241bpasero merged 2 commits intomicrosoft:masterfrom MarcoZehe:I115223
bpasero merged 2 commits intomicrosoft:masterfrom
MarcoZehe:I115223
Conversation
…to make VS Code build on ARM64 MacOS 11.2 and beyond #115223.
bpasero
approved these changes
Jan 28, 2021
joaomoreno
requested changes
Jan 28, 2021
Member
joaomoreno
left a comment
joaomoreno
left a comment
There was a problem hiding this comment.
@bpasero We can't accept PRs with changes on yarn.lock. If this is OK, run the yarn command locally yourself.
Contributor
Author
Is there an action for me to take here, or are you taking over to sort out the correct yarn.lock file format/issue? The PR is open for maintainers to push to the branch. |
Member
|
I suggest to update this PR and remove the yarn lock changes. |
bpasero
approved these changes
Feb 2, 2021
plainerman
pushed a commit
to plainerman/vscode
that referenced
this pull request
Feb 2, 2021
* Upgrade Playwright to v1.8.0. This fixes Upgrade Playwright to 1.8.0 to make VS Code build on ARM64 MacOS 11.2 and beyond microsoft#115223. * Revert changes to yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables VS Code to be built on ARM64 MacOS 11.2 and beyond. Fixes #115223.