Skip to content

debug: mark terminal as free when the associated debug session ends#115573

Merged
connor4312 merged 1 commit intomasterfrom
connor4312/debug-terminal-lifetime-fixes
Feb 2, 2021
Merged

debug: mark terminal as free when the associated debug session ends#115573
connor4312 merged 1 commit intomasterfrom
connor4312/debug-terminal-lifetime-fixes

Conversation

@connor4312
Copy link
Member

Fixes #112055

I dislike the amount of piping this took. Not sure if there's a better way.

@connor4312 connor4312 added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 1, 2021
@connor4312 connor4312 requested a review from weinand February 1, 2021 23:48
@connor4312 connor4312 self-assigned this Feb 1, 2021
Copy link
Contributor

@weinand weinand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

(Quite a few declarations needed for bringing the session ID to the ext host...)

@connor4312 connor4312 merged commit 3088c27 into master Feb 2, 2021
@connor4312 connor4312 deleted the connor4312/debug-terminal-lifetime-fixes branch February 2, 2021 16:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

debug Debug viewlet, configurations, breakpoints, adapter issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debug opens a new integrated terminal for each Python session

2 participants