Allow issue service to display a bug report window when remote extension host is crashed#116896
Merged
RMacfarlane merged 3 commits intomicrosoft:mainfrom Feb 22, 2021
Merged
Allow issue service to display a bug report window when remote extension host is crashed#116896RMacfarlane merged 3 commits intomicrosoft:mainfrom
RMacfarlane merged 3 commits intomicrosoft:mainfrom
Conversation
Update to current
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #116895 (when remote extension host is crashed, issue reporter will not appear).
The specific problem was that an attempt to call
ExtensionManagementService.getInstalled()fails if the remote extension host has died. This sometimes happens when the remote server runs out of memory or is killed for other process reasons. In that scenario, a user often sees odd errors and wants to report it, but the issue reporter doesn't work.