Updated "Code - OSS" icon for macOS Big Sur#124416
Merged
miguelsolorio merged 22 commits intomicrosoft:mainfrom Jun 16, 2021
MeyouOSS:main
Merged
Updated "Code - OSS" icon for macOS Big Sur#124416miguelsolorio merged 22 commits intomicrosoft:mainfrom MeyouOSS:main
miguelsolorio merged 22 commits intomicrosoft:mainfrom
MeyouOSS:main
Conversation
glaukiol1
approved these changes
May 22, 2021
miguelsolorio
suggested changes
May 24, 2021
Contributor
Author
|
However, my icon design template was downloaded from Apple’s official website, and there should not be any uneven shape and shadows. The corresponding website and design resource links are as follows:
Oh, what's wrong~ |
Contributor
|
We'd prefer to have all of our icons match, here's a sample of our Figma template that we used. I dropped a sample icon that you can replace. |
Contributor
Author
Contributor
|
Since we're already in endgame for this release I'm marking this for June |
Contributor
Author
|
Okay, I have merged the behind commits |
added 8 commits
June 3, 2021 14:08
Contributor
Contributor
Author
|
Okay, no problem~ @misolori |
aiwinn
approved these changes
Jun 14, 2021
miguelsolorio
approved these changes
Jun 16, 2021
Contributor
miguelsolorio
left a comment
There was a problem hiding this comment.
Awesome, this looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





This PR fixes visual inconsistency under macOS Big Sur