Accept editor line height as multiple of font size#125601
Accept editor line height as multiple of font size#125601alexdima merged 5 commits intomicrosoft:mainfrom cpsauer:line-height-multiple
Conversation
|
Tagging @alexdima, in case he's the right reviewer, since he'd been active (and kind) on the issue, and it looks like a lot of the lines in these files are his :) |
|
Actually, @alexdima, while you're looking at this: |
Head branch was pushed to by a user without write access
|
@alexdima, thanks for the review and making things better! Looks like your auto-merge got caught by linter download flakiness, so I took a sec to quickly factor the rounding out to be with the minimum constraint. Hope that's okay, since this would have needed a merge from you anyway. I'd originally had the integer constraint in there, but I noticed that the lines that follow that section break the integer font size constraint, and it looked like things work just fine with non-integer fonts, at least on macOS. Thoughts? Also hoping I can still get your thoughts on the macOS golden special-casing, above. |
|
Thank you! |
|
Sweet! Thank you, @alexdima. |
|
Any chance I could still get your take on the integer & macOS golden sub-questions above? |
This PR fixes #115960 with @appetite-j's great suggestion from #105888, also suggested by @usernamehw.
Should also fix #82778.
This is my first PR to VSCode; I'd love your help through!