Merged
Conversation
I can't really test my code because I'm having issues getting a formatter to install inside the dev build (or really any extension, seeing as `yarn install` just wants a different version of node from the one I have) but the code changes are simple and should be non-breaking. Build completes with no errors and the setting appears so I'm making the assumption everything works correctly. All I changed were a few if statements and return values.
|
|
jrieken
approved these changes
Jul 14, 2021
Member
jrieken
left a comment
jrieken
left a comment
There was a problem hiding this comment.
Not a super-fan of the name modificationsIfAvailable but we can brainstrom about that later... Otherwise, changes are look
Member
|
Thanks |
Contributor
Author
Yea I'm not a huge fan of it either. I was trying to find a blend of keeping it short and making it clear, though I did add a much longer form explanation in the tooptip about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #127838
Adds "modificationsIfAvailable" option to editor.formatOnSave. Editor will try to use modifications, and if source control is unavailable then it will format the entire file instead.
Not really sure how to test tbh, it just kinda works