Fix dragging a folder from the explorer tree to terminal no longer copies folder path#128419
Merged
meganrogge merged 5 commits intomicrosoft:mainfrom Jul 26, 2021
Merged
Fix dragging a folder from the explorer tree to terminal no longer copies folder path#128419meganrogge merged 5 commits intomicrosoft:mainfrom
meganrogge merged 5 commits intomicrosoft:mainfrom
Conversation
Collaborator
|
Thank you! Works great 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #128283
This is a regression from #125943 as
DataTransfers.RESOURCESare now only used for file resources and folders are filtered out when setting this dataTransfer type:vscode/src/vs/workbench/browser/dnd.ts
Lines 286 to 289 in a907071
Fortunately, there is
CodeDataTransfers.FILEScontaining files and folders so I'm adding that as a valid dnd type for the terminalvscode/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts
Lines 938 to 941 in a907071