Sort threads in response order#128686
Merged
isidorn merged 2 commits intomicrosoft:mainfrom Aug 2, 2021
Merged
Conversation
Return the threads in getAllThreads in the same order as they were received in the threads response. This handles the case where the thread order changes, or new threads are added that are not just appended to the list. Fixes microsoft#128546
weinand
added
the
debug
isidorn
requested changes
Jul 27, 2021
|
|
||
| rawUpdate(data: IRawModelUpdate): void { | ||
| const threadIds: number[] = []; | ||
| this.threadIds = []; |
Collaborator
There was a problem hiding this comment.
Make sure to also call this.threadIds = [] in the clearThreads method
Collaborator
|
@suzmue PR looks good. I only found one minor thing. Once you tackle that, next week I am open to merge this in. |
isidorn
approved these changes
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return the threads in getAllThreads in the same order as they
were received in the threads response. This handles
the case where the thread order changes, or new threads are
added that are not just appended to the list.
This PR fixes #128546