Quick pick icons vertical alignment fix.#128950
Merged
TylerLeonhardt merged 2 commits intomicrosoft:mainfrom Jul 20, 2021
Merged
Quick pick icons vertical alignment fix.#128950TylerLeonhardt merged 2 commits intomicrosoft:mainfrom
TylerLeonhardt merged 2 commits intomicrosoft:mainfrom
Conversation
Vertical alignment of right icons fixed by removing an extra 2px top padding. Closes: microsoft#124382
Member
|
Thanks for this! Looks better. @franzvill did you want to also try to fix the left icons too? |
Icons in the left part of the quick picker centered in their container by chaging the vertical align from sub to text-bottom.
Contributor
Author
|
Sure, here's the new change: Before:
After:
|
Tyriar
reviewed
Jul 20, 2021
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Does this make files look differently (ctrl+p)?
Contributor
Author
|
The file icons? They stay unchanged and they were already centered:
|
Tyriar
approved these changes
Jul 20, 2021
TylerLeonhardt
approved these changes
Jul 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vertical alignment of right icons fixed by removing an extra 2px top
padding.
Before:
After:
This PR fixes #124382