Persist KaTeX macros across render calls#129747
Merged
mjbvz merged 2 commits intomicrosoft:mainfrom Aug 5, 2021
Merged
Conversation
Collaborator
|
Thanks! This will be in the next insiders build and is scheduled for VS Code 1.60 |
Collaborator
|
Were you seeing this working? I just merged this but when I tested the above equation, it still shows: |
Contributor
Author
|
@mjbvz No, I didn't actually build VSCode with my changes. (It would really nice to have GitHub Codespaces to try out new builds!) I was hoping that this would just work, but I guess I wasn't lucky this time. Any chance you could help debug this? Being able to persist KaTeX macros across render calls would be a huge plus for me. |
Collaborator
|
Ok, please try building and debugging VS Code locally to see what may be going wrong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the regression identified in #125425.
Sets the "globalGroup" option in KaTeX to
truefor both markdown file previews and for notebook cell rendering.Now, markdown such as the following should render properly:
$\newcommand{\ra}{\rightarrow}$ $\ra$