Copy URI authority from base when splitting terminals, fixes #127811#130291
Merged
Tyriar merged 1 commit intomicrosoft:mainfrom Aug 16, 2021
Merged
Copy URI authority from base when splitting terminals, fixes #127811#130291Tyriar merged 1 commit intomicrosoft:mainfrom
Tyriar merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
Hi @Tyriar, @meganrogge, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #127811
I noticed that when splitting the terminal, the
authorityproperty of the URI was empty.Thus, this if statement is false and
this._launchLocalProcessis called instead of creating a new remote terminal.