feat: add asWebviewUri test with port in name#131447
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Aug 24, 2021
Merged
Conversation
This PR adds another test for asWebviewUri to ensure that everything works es expected even with a port number in the webview authority. We do this because there are open source versions of VS Code which run on localhost and have had issues in the past with resources not loading in webviews.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds another test for asWebviewUri to ensure that everything works es
expected even with a port number in the webview authority.
We do this because there are open source versions of VS Code which run on
localhost and have had issues in the past with resources not loading in
webviews.
This PR is related to #130151