fix: early return on cancellation#132523
Merged
aeschli merged 1 commit intomicrosoft:mainfrom Sep 9, 2021
AkatQuas:fix/runner
Merged
fix: early return on cancellation#132523aeschli merged 1 commit intomicrosoft:mainfrom AkatQuas:fix/runner
aeschli merged 1 commit intomicrosoft:mainfrom
AkatQuas:fix/runner
Conversation
Contributor
|
Thanks @AkatQuas ! |
aeschli
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes # None
Compared the logic in
runSafe, it might be possible to early return to save thefunc()invocation.