fix: Screencast Mode - keyboard overlay timeout

[newminkyung]

• fix: Screencast mode: keyboard overlay timeout does not respect the value #238745

2025-01-28.12.48.54.mov

Overview

This PR resolves an issue where changes to the screencastMode.keyboardOverlayTimeout setting were not being immediately reflected in the Screencast Mode keyboard overlay.

Key Changes

• Updated the clearKeyboardScheduler.schedule() method to accept the keyboardMarkerTimeout value dynamically.
  • Previously, the timeout value was fixed when the RunOnceScheduler was initialized.
  • With this change, the updated timeout value is immediately applied without requiring a scheduler restart.

Expected Outcome

• The keyboard overlay timeout in Screencast Mode now updates in real-time when the screencastMode.keyboardOverlayTimeout setting is modified.
• Users will experience immediate changes to the overlay duration without any additional steps.

Testing

• Verified that updating the screencastMode.keyboardOverlayTimeout value in settings.json dynamically adjusts the keyboard overlay timeout in Screencast Mode.
• Confirmed that the overlay disappears after the specified duration for various timeout values (e.g., 500ms, 5000ms).

[ohah]

thx

[joaomoreno]

Thanks! 🍻

[vs-code-engineering]

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

• src/vs/workbench/browser/actions/developerActions.ts

[Copilot]

Pull request overview

This PR fixes an issue where changes to the screencastMode.keyboardOverlayTimeout setting were not immediately reflected in the Screencast Mode keyboard overlay. The fix ensures that timeout updates are applied dynamically by passing the current timeout value to the scheduler's schedule() method.

Key Changes:

• Modified three clearKeyboardScheduler.schedule() calls to accept the keyboardMarkerTimeout parameter, enabling real-time timeout updates