Added Enabled View to Extension Viewlet#25974
Added Enabled View to Extension Viewlet#25974gonzofish wants to merge 3 commits intomicrosoft:masterfrom
Conversation
Set it to default extensions pane to enabled Added action to command palette as well
|
@gonzofish, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @joaomoreno to be potential reviewers. |
|
@gonzofish, It will cover your contributions to all Microsoft-managed open source projects. |
|
@gonzofish, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
joaomoreno
left a comment
There was a problem hiding this comment.
I like that the user can filter out the disabled extensions. But I don't think that should be the default behaviour. I would keep the @installed view as the default behaviour.
|
You know, I thought that too but followed the feature request...I'll change
it
…On Fri, May 5, 2017 at 6:39 AM João Moreno ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I like that the user can filter out the disabled extensions. But I don't
think that should be the default behaviour. I would keep the @installed
view as the default behaviour.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25974 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYjrpxshyiNdh-antPuY3t5F7n9HsyYks5r2vx5gaJpZM4NRdXb>
.
|
|
I was wondering if this feature is ready to be merged. I'm happy to give some help. Thanks |
|
Yeah me too. I updated it as requested but never heard anything after. |
|
@gonzofish Sorry for not looking into this.. I will take a look.. But may I know is it possible to resolve the conflicts? |
|
@sandy081 no worries! I hadn't noticed the conflicts. I can definitely fix them today. |
|
Hi @gonzofish, I don't want to be "push", so I was wondering If you could give me access to this branch, so I can help fixing the conflicts, in case you've been busy. Thanks |
|
@sandy081 this is #30367 on top of @gonzofish's changes which only fixes the merge conflicts. |
|
@bugrac Thanks. Will take a look. |
|
@bugrac thanks for updating in my absence I had some things come up and was away from Internet access for the last week, sorry for the radio silence |
|
@gonzofish Merged the PR from @bugrac. |
Addresses #22866
Added Enabled action to extensions viewlet
Added "Extensions: Show Enabled Extensions" action to workbench
Set showing enabled in extensions to default view when opening extensions viewlet