Skip to content

Don't hardcode number of result providers#28115

Merged
chrmarti merged 3 commits intomicrosoft:masterfrom
nicksnyder:quickopen
Jun 7, 2017
Merged

Don't hardcode number of result providers#28115
chrmarti merged 3 commits intomicrosoft:masterfrom
nicksnyder:quickopen

Conversation

@nicksnyder
Copy link
Contributor

Minor refactor. Does not change any logic.

Minor refactor. Does not change any logic.
@chrmarti
Copy link
Collaborator

chrmarti commented Jun 7, 2017

Thanks for your contribution @nicksnyder. A few thoughts:

Instead of searching and casting for the FileQuickOpenModel, could we just .then on the promise we know returns that model: https://github.com/Microsoft/vscode/blame/master/src/vs/workbench/parts/search/browser/openAnythingHandler.ts#L164

Also: [].concat(...results.map(r => r.entries)) would be shorter and maybe slightly more efficient than the reduce approach.

@nicksnyder
Copy link
Contributor Author

@chrmarti Thanks for the suggestions! I updated the PR.

@chrmarti chrmarti merged commit 61fa6e8 into microsoft:master Jun 7, 2017
@chrmarti
Copy link
Collaborator

chrmarti commented Jun 7, 2017

Thanks @nicksnyder !

@nicksnyder nicksnyder deleted the quickopen branch June 7, 2017 21:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants