Fix: Do not suggest implicit activation message when engine does not support it#281302
Merged
alexdima merged 3 commits intomicrosoft:mainfrom Jan 16, 2026
Merged
Conversation
dmitrivMS
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #251898
Summary
This PR addresses the issue where the linter would incorrectly suggest bumping the engine version to
^1.75.0even when the extension author intentionally targeted an older version. It also fixes a bug in the version check logic that would have caused failures for future major versions (e.g.,2.0.0).Changes
major >= 1 && minor >= 75was flawed because it would fail for version2.0.0(since0 < 75). I updated it to correctly handlemajor > 1.bumpEngineForImplicitActivationEventsvariable.Verification
1.74.0-> Correctly identified as NOT supporting implicit activation.1.75.0,1.80.0-> Correctly identified as supporting it.2.0.0-> Fix verified: Now correctly identified as supporting it.extension-editingextension successfully withgulp compile-extension:extension-editing.