Spaces in block comment. #28169#28238
Spaces in block comment. #28169#28238alexdima merged 3 commits intomicrosoft:masterfrom yzhang-gh:master
Conversation
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
alexdima
left a comment
There was a problem hiding this comment.
Thank you for your contribution. At this time, this PR breaks 13 tests. Could you please look into changing tests where it makes sense and fixing any introduced regressions ?
|
I've fixed the tests. But I have no idea about this one ... |
|
@neilsustc, It will cover your contributions to all Microsoft-managed open source projects. |
|
@neilsustc Thank you, I have closed and reopened the PR to get travis to rerun the build. This has also triggered our Contribution License Agreement bot to re-evaluate the PR, and, due to the increase in changed lines count, it now requires an agreement. Could you please go through the flow the bot asks for, it is very simple. |
|
@neilsustc, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
Thanks for your patience 😉 |
|
Very nice. Thank you for your contribution @neilsustc ❤️ |
This PR: microsoft/vscode#28238 inserts spaces inside block comments, which affects VSCodeVim tests.
This PR: microsoft/vscode#28238 inserts spaces inside block comments, which affects VSCodeVim tests.
Resolve #28169.
According to that in
lineCommentCommand.ts.