Skip to content

add more settings to gear menu#28303

Merged
isidorn merged 2 commits intomicrosoft:masterfrom
jens1o:jens1o-theme-settings-to-gear
Jun 9, 2017
Merged

add more settings to gear menu#28303
isidorn merged 2 commits intomicrosoft:masterfrom
jens1o:jens1o-theme-settings-to-gear

Conversation

@jens1o
Copy link
Contributor

@jens1o jens1o commented Jun 9, 2017

resolves #28248

@msftclas
Copy link

msftclas commented Jun 9, 2017

@jens1o,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@isidorn
Copy link
Collaborator

isidorn commented Jun 9, 2017

@jens1o thanks for your PR. Always make sure to first try out the PR before submiting it. Here are things which should be fixed before we can merge it in:

  • The title of "Select File Icon Theme" should be just "File Icon Theme" like in the preferences menu. For consistency and conciseness
  • You got the order wrong, first should be the color theme, and only then file icon theme. Since the first is more important and that is how it is currently in preferences

screen shot 2017-06-09 at 12 45 06

@jens1o
Copy link
Contributor Author

jens1o commented Jun 9, 2017

Actually, I wanted to set "Select Color Theme", but I found no message for that, and I was unsure whether I can introduce new messages, and I was waiting for this feedback. Sorry for the inconvenience. This pr was on purpose(and tested), and personally I change the file icon theme more often, that's why I ordered it how I did.

@jens1o
Copy link
Contributor Author

jens1o commented Jun 9, 2017

nevermind, I fixed it.

@isidorn isidorn merged commit 0bdc776 into microsoft:master Jun 9, 2017
@isidorn
Copy link
Collaborator

isidorn commented Jun 9, 2017

Looks good, great work!

@jens1o jens1o deleted the jens1o-theme-settings-to-gear branch June 9, 2017 11:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add other settings to the gear menu

3 participants