add more settings to gear menu#28303
Merged
isidorn merged 2 commits intomicrosoft:masterfrom Jun 9, 2017
Merged
Conversation
|
@jens1o, |
Collaborator
|
@jens1o thanks for your PR. Always make sure to first try out the PR before submiting it. Here are things which should be fixed before we can merge it in:
|
Contributor
Author
|
Actually, I wanted to set "Select Color Theme", but I found no message for that, and I was unsure whether I can introduce new messages, and I was waiting for this feedback. Sorry for the inconvenience. This pr was on purpose(and tested), and personally I change the file icon theme more often, that's why I ordered it how I did. |
Contributor
Author
|
nevermind, I fixed it. |
Collaborator
|
Looks good, great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

resolves #28248