Shrink terminal find widget to max terminal width#30348
Merged
mjbvz merged 3 commits intomicrosoft:masterfrom Jul 10, 2017
Merged
Shrink terminal find widget to max terminal width#30348mjbvz merged 3 commits intomicrosoft:masterfrom
mjbvz merged 3 commits intomicrosoft:masterfrom
Conversation
Member
|
Cool 😃 I think it should have similar margin on the left to the editor (see #29795 (comment)) |
Tyriar
reviewed
Jul 10, 2017
Member
There was a problem hiding this comment.
Might be better to keep the default smaller for now since there's no clever adding padding to top like in the editor. The find result is also shown on the first line generally so the chance of a collision is fairly high.
Shrink the terminal find widget to fit within the max terminal size
mjbvz
force-pushed
the
shrink-terminal-find-widget
branch
from
849ac12 to
7ca7a8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29795
Shrink the terminal find widget to fit within the max terminal size