Skip to content

editor.insertSpaceAfterComment setting#41747

Merged
alexdima merged 7 commits intomicrosoft:masterfrom
muravjov:insertSpaceAfterComment
Jan 19, 2020
Merged

editor.insertSpaceAfterComment setting#41747
alexdima merged 7 commits intomicrosoft:masterfrom
muravjov:insertSpaceAfterComment

Conversation

@muravjov
Copy link
Contributor

Hi,

Please look at my PR, which introduces setting editor.insertSpaceAfterComment to make VScode to format line comments like

		//model.tokenizeIfCheap(startLineNumber);

instead of

		// model.tokenizeIfCheap(startLineNumber);

(no space just after //)

By default original behaviour is remained, with the space.

@msftclas
Copy link

msftclas commented Jan 17, 2018

CLA assistant check
All CLA requirements met.

@muravjov
Copy link
Contributor Author

One more need about not inserting space: #9879 (comment)

@muravjov muravjov force-pushed the insertSpaceAfterComment branch from f2991ca to 9fd4b42 Compare January 30, 2018 01:03
@muravjov muravjov force-pushed the insertSpaceAfterComment branch 9 times, most recently from cf35684 to 18c1e8d Compare February 16, 2018 10:05
@muravjov muravjov force-pushed the insertSpaceAfterComment branch from 18c1e8d to 94f10a4 Compare February 17, 2018 09:28
@muravjov
Copy link
Contributor Author

Finally I've been able to get through all checks.

@muravjov
Copy link
Contributor Author

Hi @alexandrudima ,
any chance for taking up my PR?

@alexdima alexdima added this to the April 2018 milestone Mar 29, 2018
@alexdima alexdima removed this from the April 2018 milestone Apr 27, 2018
@lbmaian
Copy link

lbmaian commented Sep 26, 2019

Any possibility of getting this merged in? I've been resorting to local patching _createAddLineCommentsOperations to get rid of the space after the //, which of course results in an "unsupported" warning for VS Code.

@kirkouimet
Copy link

Let's merge this in!

@alexdima alexdima added this to the January 2020 milestone Jan 19, 2020
@alexdima
Copy link
Member

Thank you!

@alexdima alexdima merged commit a3d4675 into microsoft:master Jan 19, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants