Ask to add known huge folders to .gitignore, fixes #44304#44562
Ask to add known huge folders to .gitignore, fixes #44304#44562joaomoreno merged 4 commits intomicrosoft:masterfrom
Conversation
There was a problem hiding this comment.
There's a lot about this which is suboptimal. The user should know which folders would be added to gitignore. This doesn't check whether node_modules is already in gitignore at all. This should also be done before any large git status even runs; right now, the Repository will still get into a isRepositoryHuge = true state... the user would still have to reload to get out of it, even after adding to gitignore.
|
@joaomoreno Thanks for the review. I tried to solve the issues you mentioned:
done
I used the existing
This was solved by saving the |
This is not true. The repository will be in a |
|
If the user presses 'Yes' to the prompt, So, the only case I'm missing is 'when the user modifies .gitignore manually' (right?). How about we use |
fixes #44304