Prevent scrollbar to be considered as a drop target for drag-and-drop#49747
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Sep 11, 2018
Merged
Prevent scrollbar to be considered as a drop target for drag-and-drop#49747joaomoreno merged 1 commit intomicrosoft:masterfrom
joaomoreno merged 1 commit intomicrosoft:masterfrom
Conversation
Member
|
Thanks! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #48929
The approach here is to prevent scrollbar to be not considered a drop target when searching on
dragoverordragleave. This behaviour is similar to how MacOS handles drag and drop while hovering on the scrollbar in Finder.Another approach is basically to add
dropevent listener on thedomNodeinstead ofwrapperwhich will allow the user to drop any item on the scrollbar but the file will be dropped on the top level of the folder structure instead of in the scrolled position.Let me know if you want another approach instead of the one in this PR.