fixed:generator method of class autocomplete causes star(*) to be add…#51557
Merged
alexdima merged 3 commits intomicrosoft:masterfrom Sep 11, 2018
Merged
fixed:generator method of class autocomplete causes star(*) to be add…#51557alexdima merged 3 commits intomicrosoft:masterfrom
alexdima merged 3 commits intomicrosoft:masterfrom
Conversation
Author
|
@misolori do you need anything from me to merge this PR? |
Contributor
|
@limerickgds I'll let @aeschli handle this PR |
Collaborator
|
@alexandrudima / @rebornix Can you please take a look at this |
Author
Contributor
|
@alexandrudima and @rebornix have the final word here, but looking at the previous line looks fishy to me. For other language configurations we can already express where the rule applies: Ideally, we can add the same for |
Author
|
@aeschli do you need i change this PR ? |
Member
|
I personally kind of like it that the implemention of @limerickgds Thank you ! |
alexdima
reviewed
Sep 11, 2018
Member
|
creates #58440 as tracking item |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i add a onEnterRule rule that will only execute if the text above the this line matches /** or *.
but i don't think this is a good solution.
Fixes #43469
cc: @joaomoreno