add option for input validation foreground color#57734
add option for input validation foreground color#57734bpasero merged 6 commits intomicrosoft:masterfrom
Conversation
bpasero
left a comment
There was a problem hiding this comment.
@ParkourKarthik unless I am mistaken, these colors should not have any default set, otherwise we change the semantics, aren't we? Today I do not think we apply any particular foreground color by default and I think we should only do so if the theme defines this color explicitly.
Also, we need to support this color everywhere where the correlating background color is passed through, so please find all occurrences of where input background colors are used and pass them through.
|
@bpasero I've set the default values to Note: I've not added any Validation Foreground colors to the below as there should not be defaults for Foreground. |
bpasero
left a comment
There was a problem hiding this comment.
@ParkourKarthik much better. There is one remaining usage of inputValidationInfoBackground in messageController that can also have a foreground color from the theme.
|
Thanks 🍺 |
This closes #57536
@bpasero I've made changes only related to "find Input control".
Review and let me know if similar changes could be applied to all other input validations.