Fix #57222 - improve no user.email/user.name config error message#58174
Merged
joaomoreno merged 3 commits intomicrosoft:masterfrom Sep 13, 2018
Merged
Fix #57222 - improve no user.email/user.name config error message#58174joaomoreno merged 3 commits intomicrosoft:masterfrom
joaomoreno merged 3 commits intomicrosoft:masterfrom
Conversation
|
Is there a possibility to show current email and name config? |
Contributor
Author
|
Now the error message looks like this: @dzienisz is this better? |
|
@Git-Lior I think so. Thanks! |
Contributor
|
For consistency, maybe flip the two current lines so email comes first and name comes second? |
Contributor
Author
|
@mc10 you're correct, done 👍 |
Member
|
Thanks! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The new message looks like this:
Tell me if anything can be improved. Thanks!