Add missing access keys (mnemonics) for menu items#58412
Merged
sbatten merged 2 commits intomicrosoft:masterfrom Sep 11, 2018
rik-smeets:add-missing-access-keys
Merged
Add missing access keys (mnemonics) for menu items#58412sbatten merged 2 commits intomicrosoft:masterfrom rik-smeets:add-missing-access-keys
sbatten merged 2 commits intomicrosoft:masterfrom
rik-smeets:add-missing-access-keys
Conversation
|
|
…uration, Enable All Breakpoints and Auto Save
Member
|
Thanks @rik-smeets, I've added the mnemonics to the native menu system for consistency. |
sbatten
approved these changes
Sep 11, 2018
|
I believe this change is causing issues on the most recent Code Insiders (Version 1.28.0-insider (1.28.0-insider).
As you can see, some & is being displayed on Check for Updates option. This is also occuring in other Menu Options. |
Closed
Contributor
Author
|
@joaosamouco I think so too, see #58603 for my quick analysis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing access keys (mnemonics) for:
When I was looking at the improvements done by @sbatten with regards to #54349, I noticed some access keys were missing. I added those in this pull request.