Resolves #57507 - Allows clicking of Modified In labels in setting editor view

[w9jds]

Exposed target changing in the action bar, and moved the Modified In label to a link. This should properly switch between views and automatically filter the list based on category and label name.

[roblourens]

This is great! My comments:

• Only the scope name should be underlined, like "Also modified in: __User__"
• Instead of putting the display name in the search bar, put the setting key (files.autoSave) there. Then only that one setting will be displayed.

[w9jds]

🤦‍♂️ That makes way more sense than just assuming the first item in the array

[roblourens]

Won't this always reference the last item in the list, because it will point to i in the closure scope, which is always incremented to the length of the list?

[w9jds]

Huh, that is a fantastic point, let me test it really quick.

[w9jds]

No, testing locally seems to indicate that when it creates the listener and anonymous function is retains the state of the scoped variable. When I manually pushed in a second option it properly used the correct index on click.

[roblourens]

You're right - seems that this works with let but does not work with var. I can't drop the old school habits.

[roblourens]

Can we keep the () around the text?

[w9jds]

Definitely! I'll add it now.

[roblourens]

Looks great, thanks!