Fixed #59395 - Emmet Syntax Profiles tag_nl produces no extra space

[irrationalRock]

This PR fixes #59395.

With:

"emmet.syntaxProfiles": {
        "html": {
            "tag_nl": false            
        }
    },

It no longer allows extra space.

Before:

After:

Thanks for considering this request.

[ramya-rao-a]

The tests seem to be failing. Can you take a look at that?

To run the tests locally, run scripts\test-integration.bat on Windows or ./scripts/test-integration.sh on Linux/Mac

It would also do us good to add a test case to cover this scenario.
wrapWithAbbreviation.test.ts would be the file to update.

[ramya-rao-a]

We can probably get the value for tag_nl from expandOptions.profile object

[irrationalRock]

Thanks for the feedback. I'm looking at the tests and will update tag_nl to expandOptions.profile

[irrationalRock]

I updated my code to use expandOptions.profile. I'm wondering if you can give me an example of how to change the config in tests. I am having some problems trying to change tag_nl to false.

[ramya-rao-a]

My apologies, I should have cleared some things previously.

The new emmet modules that we use dont use the same syntaxProfile settings as documented in https://docs.emmet.io/customization/syntax-profiles/

The new emmet modules follow the profile as defined in https://github.com/emmetio/output-profile/blob/1a7571e78da9d7bf056289b3396dbb0bcc45c435/types.d.ts#L1

To support backward compatibility in VS Code, we support both in the settings. I convert the old profile to a new one using a helper

So now coming to the current issue. You can just add expandOptions['format'] === true to the if condition and that should be enough.

[ramya-rao-a]

I'm wondering if you can give me an example of how to change the config in tests.

https://github.com/Microsoft/vscode/blob/release/1.28/extensions/emmet/src/test/abbreviationAction.test.ts#L441 is an example where I changed the config for the emmet.excludeLanguages setting. You can use that as an example.

[irrationalRock]

Thanks for the help. I had to use expandOptions['profile'].format instead of expandOptions['format'] because it didn't seem to produce any properties when tag_nl was set to true.
I also added tests for this feature.

[irrationalRock]

It seems like my commits fail when running the hygiene tests. Is there any way for me to run these tests on my local machine? Running ./scripts/test-integration.sh passes all of the tests.

[ramya-rao-a]

The hygiene failure was due to formatting errors. I have pushed a change to fix that.

[contentfree]

Wrap still produces incorrect results if tag_nl_leaf is false, I believe. (tag_nl_leaf doesn't seem to be respected at all, really, nor does the 'decide' value for tag_nl)

[ramya-rao-a]

@contentfree I have logged an upstream issue for that. See https://github.com/emmetio/output-profile/issues/1