Add setting to allow to disable Replace Preview#60153
Merged
roblourens merged 3 commits intomicrosoft:masterfrom Oct 9, 2018
ToothlessGear:feature_allow_disabling_replace_preview_setting
Merged
Add setting to allow to disable Replace Preview#60153roblourens merged 3 commits intomicrosoft:masterfrom ToothlessGear:feature_allow_disabling_replace_preview_setting
roblourens merged 3 commits intomicrosoft:masterfrom
ToothlessGear:feature_allow_disabling_replace_preview_setting
Conversation
Introduces a new settings option "search.useReplacePreview" which allows you to disable "Replace Preview" during a Search/Replace. Closes #60027
roblourens
requested changes
Oct 8, 2018
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Can you check whether we need to check the setting here too? https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/search/browser/searchActions.ts#L581
src/vs/workbench/parts/search/electron-browser/search.contribution.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi, regarding https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/search/browser/searchActions.ts#L581. |
Member
|
I see it when clicking the replace button in a file with a bunch of matches. |
Contributor
Author
|
I think I got it now, thanks for taking the time to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new settings option "search.useReplacePreview" which
allows you to disable "Replace Preview" during a Search/Replace.
Closes #60027