Skip to content

Fix #27393: Fix explorer inputbox alignment#60539

Merged
isidorn merged 1 commit intomicrosoft:masterfrom
garymathews:issue-27393
Oct 15, 2018
Merged

Fix #27393: Fix explorer inputbox alignment#60539
isidorn merged 1 commit intomicrosoft:masterfrom
garymathews:issue-27393

Conversation

@garymathews
Copy link
Contributor

TEST CASE
  • Rename a file in Explorer
  • Filename should not shift when switching between edit mode

@garymathews garymathews changed the title ISSUE 27393: Fix explorer inputbox alignment Fix #27393: Fix explorer inputbox alignment Oct 10, 2018
@bpasero bpasero assigned isidorn and unassigned bpasero Oct 11, 2018
@isidorn isidorn added this to the October 2018 milestone Oct 11, 2018
@isidorn
Copy link
Collaborator

isidorn commented Oct 11, 2018

Thanks for the PR, it is good, and works nicely on OS X.
On windows now the item is not pushed, however the blue top focus border is eaten up becuase the top is moved by -1px. This looks broken.
Can we fix this in some other way such that the focus does not get eaten away.
For me it feels like the actual issue is that the element is not properly centered in the input box when we start renaming.

@garymathews
Copy link
Contributor Author

@isidorn Updated PR based on review feedback for Windows changes.

@isidorn
Copy link
Collaborator

isidorn commented Oct 15, 2018

Good job, works nice now.
Thanks a lot

@isidorn isidorn merged commit 55ed150 into microsoft:master Oct 15, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants