Skip to content

Fixes #60724 - Terminal:SelectBox: Terminal select box should have main ARIA label#61466

Merged
cleidigh merged 1 commit intomicrosoft:masterfrom
skprabhanjan:fix-60724
Oct 23, 2018
Merged

Fixes #60724 - Terminal:SelectBox: Terminal select box should have main ARIA label#61466
cleidigh merged 1 commit intomicrosoft:masterfrom
skprabhanjan:fix-60724

Conversation

@skprabhanjan
Copy link
Contributor

@cleidigh
cc : @Tyriar
This fixes #60724 , just changed the label value.
PS: The entire interface is not passed as you had suggested.

@cleidigh
Copy link
Contributor

@skprabhanjan
Looks good.
Tweak the PR title to be clear what this is beyond just the "Fixes #XYZ" - makes tracking easier.
then I will merge...

@skprabhanjan skprabhanjan changed the title Fixes #60724 Fixes #60724 - Terminal:SelectBox: Terminal select box should have main ARIA label Oct 23, 2018
@skprabhanjan
Copy link
Contributor Author

@skprabhanjan
Looks good.
Tweak the PR title to be clear what this is beyond just the "Fixes #XYZ" - makes tracking easier.
then I will merge...

@cleidigh , sorry for that!
Hope its good now, Thanks :)

@cleidigh cleidigh merged commit 9b19f82 into microsoft:master Oct 23, 2018
@Tyriar Tyriar added this to the October 2018 milestone Oct 23, 2018
@AndreiShybin
Copy link

9b19f82

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal:SelectBox: Terminal select box should have main ARIA label

5 participants