#61410 Add keybinding to "Find in Folder" action#61526
#61410 Add keybinding to "Find in Folder" action#61526roblourens merged 3 commits intomicrosoft:masterfrom
Conversation
|
@roblourens I'm not sure we're meant to use ctrl+alt+ as default keybindings? |
|
|
|
How about |
Works fine when having selected a folder. But fires code formatting when focused in editor and opens File menu when focused on a file (not folder) in Side Explorer. None of those are happening with Ctrl+Alt+f. Still, I might be missing bigger picture here therefore I can lean towards your suggestion. |
|
So I filed #61644 for the File menu opening when alt+shift+f is pressed, because that seems wrong. I like that keybinding so let's wait just a bit to see where that goes. |
|
Ok that other issue has been fixed, I think alt+shift+f is a good shortcut. But it's too late for the October release. You can update the PR anytime and I'll merge it next week for the November release. |
maxbarnas
force-pushed
the
feature/gh-61410-search-in-folder-keybinding
branch
from
c83aa63 to
4e80aaa
Compare
|
I've changed the key binding but some pipelines failed for (apparently) no good reason. Is there a way to rerun them? Edit: Nevermind, I rebased onto updated master and pipelines passed fine |
maxbarnas
force-pushed
the
feature/gh-61410-search-in-folder-keybinding
branch
from
06cd9f9 to
6d28eaf
Compare
|
Sorry, I forgot about this PR. Taking a look now. |
src/vs/workbench/parts/search/electron-browser/search.contribution.ts
Outdated
Show resolved
Hide resolved
…ributions.ts because of import limitations on /browser/* files
maxbarnas
force-pushed
the
feature/gh-61410-search-in-folder-keybinding
branch
from
d1a45b8 to
8dc19f2
Compare
4 participants
Resolves #61410
Decided to go with proposed cmd+alt+f / ctrl+alt+f
I left the handler in
search.contibutions.tsbecause of import linting rules onworkbench/parts/*/browser/*files. Happy to fix that if pointed how.