multiline breakpoint widget - implementing #56521#61859
multiline breakpoint widget - implementing #56521#61859isidorn merged 2 commits intomicrosoft:masterfrom
Conversation
|
Thanks for the PR. |
There was a problem hiding this comment.
Use a proper name, not _ even though it is not used
There was a problem hiding this comment.
I prefer const to let if it will not be mutated, so can you please use const
There was a problem hiding this comment.
This is a listener, add it to the this.toDispose
There was a problem hiding this comment.
Same here, please use const
|
@YisraelV great work, I really like it. I checked for the css change, and I can no longer reproduce the original bug so we are good there. You do not have to worry about that. |
|
@isidorn that's very nice to hear thank you very much. I made the requested changes. Would you like me to squash my two commits into 1? |
|
@YisraelV no need for squashing, merging it in. Thanks a lot! |
No description provided.