Skip to content

Suppress display of end-of-file newline as blank line#64667

Merged
alexdima merged 3 commits intomicrosoft:masterfrom
pedromsfernandes:eof-nl
Feb 18, 2019
Merged

Suppress display of end-of-file newline as blank line#64667
alexdima merged 3 commits intomicrosoft:masterfrom
pedromsfernandes:eof-nl

Conversation

@pedromsfernandes
Copy link
Contributor

Fixes #1027.
We read the thread and the consensus seemed to be that there should be a setting that controls the display of the numbered blank line at the end of files. So that's what we did. We're not sure if we used the most correct naming, but after a couple of tests it does seem to work as intended. Here are some screenshots:

Added setting
eof-nl-setting

No blank like
eof-no-nl

Setting on
eof-nl-on

Setting off
eof-nl-off

@msftclas
Copy link

msftclas commented Dec 8, 2018

CLA assistant check
All CLA requirements met.

@alexdima alexdima force-pushed the eof-nl branch 4 times, most recently from 31a41ac to 21d7583 Compare February 18, 2019 10:18
@alexdima alexdima merged commit 3d662dd into microsoft:master Feb 18, 2019
@alexdima alexdima added this to the February 2019 milestone Feb 18, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suppress display of end-of-file newline as blank line

5 participants