Skip to content

Fixes #27107 - User terminal's cwd for links#64750

Merged
Tyriar merged 2 commits intomicrosoft:masterfrom
nojvek:nojvek-terminal-cwd
Dec 10, 2018
Merged

Fixes #27107 - User terminal's cwd for links#64750
Tyriar merged 2 commits intomicrosoft:masterfrom
nojvek:nojvek-terminal-cwd

Conversation

@nojvek
Copy link
Contributor

@nojvek nojvek commented Dec 10, 2018 •
edited
Loading

Implementation Details:

  • renaming initialCwd -> processCwd
  • debounce _updateProcessCwd with a 2 second
  • only call _updateProcessCwd when user presses enter on xterm

@Tyriar Tyriar added this to the December 2018 milestone Dec 10, 2018
@Tyriar Tyriar self-assigned this Dec 10, 2018
Tyriar
Tyriar approved these changes Dec 10, 2018
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Tyriar Tyriar merged commit 0d375bf into microsoft:master Dec 10, 2018
@Tyriar Tyriar mentioned this pull request Dec 10, 2018
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

December/January 2019

Development

Successfully merging this pull request may close these issues.

2 participants

@nojvek @Tyriar