Fix #64253 - Support ~/ paths for typescript.tsdk#64892
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Dec 14, 2018
Merged
Fix #64253 - Support ~/ paths for typescript.tsdk#64892mjbvz merged 2 commits intomicrosoft:masterfrom
mjbvz merged 2 commits intomicrosoft:masterfrom
Conversation
mjbvz
reviewed
Dec 13, 2018
Collaborator
mjbvz
left a comment
mjbvz
left a comment
There was a problem hiding this comment.
Looks good. Thanks! Just a small requested change
extensions/typescript-language-features/src/utils/configuration.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mjbvz , Here is an implementation based on the inputs you gave to fix #64253 .
Please review this and let me know if anything needs to be changed :)
Thanks!