Skip to content

Enable strict null checking for quickOpenScorer test#65299

Merged
mjbvz merged 2 commits intomicrosoft:masterfrom
usernamehw:strict_null_quickOpenScorer
Dec 19, 2018
Merged

Enable strict null checking for quickOpenScorer test#65299
mjbvz merged 2 commits intomicrosoft:masterfrom
usernamehw:strict_null_quickOpenScorer

Conversation

@usernamehw
Copy link
Contributor

@usernamehw usernamehw commented Dec 18, 2018

#65233

  • "./vs/base/parts/quickopen/test/common/quickOpenScorer.test.ts"

bpasero
bpasero requested changes Dec 18, 2018
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this is just a test, this hurts my eyes: void 0 as any as string.

/cc @mjbvz

@bpasero bpasero assigned mjbvz and unassigned bpasero Dec 18, 2018
@mjbvz mjbvz added this to the December/January 2019 milestone Dec 19, 2018
@mjbvz mjbvz merged commit 33ed0d8 into microsoft:master Dec 19, 2018
@usernamehw usernamehw deleted the strict_null_quickOpenScorer branch December 19, 2018 21:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bpasero bpasero bpasero requested changes

Assignees

@mjbvz mjbvz

Labels

None yet

Projects

None yet

Milestone

December/January 2019

Development

Successfully merging this pull request may close these issues.

3 participants

@usernamehw @bpasero @mjbvz