Converted another ~70 test files to strictNullChecks#65672
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Dec 28, 2018
JoshuaKGoldberg:strict-null-checks-auto-2
Merged
Converted another ~70 test files to strictNullChecks#65672mjbvz merged 2 commits intomicrosoft:masterfrom JoshuaKGoldberg:strict-null-checks-auto-2
mjbvz merged 2 commits intomicrosoft:masterfrom
JoshuaKGoldberg:strict-null-checks-auto-2
Conversation
added 2 commits
December 25, 2018 14:23
These are the remaining test files that didn't require any changes to non-test file types. I'll send those in separately. Most changes were automatic and small (`!`s). The only non-trival change is that `extHostSearch.ts` needs an interface for its test data. Again used [TypeStat](https://github.com/JoshuaKGoldberg/TypeStat) when possible per #65581. I'm happy to split this up into smaller PRs if you'd prefer!
Collaborator
|
Thanks! Those test files include files that are not yet strict null checked. The test file changes look good to me but I think we need to hold off on adding them to the I'm going to merge and then revert the changes to only the tsconfing |
mjbvz
added a commit
that referenced
this pull request
Dec 28, 2018
See #65672 Not all of these files only import strict null check eligible files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the remaining test files in #65233 that didn't require any changes to non-test file types. I'll send those in separately.
Most changes were automatic and small (
!s).The only non-trival change is that
extHostSearch.tsneeds an interface for its test data.Again used TypeStat when possible per #65581. I'm happy to split this up into smaller PRs if you'd prefer!
Edit: Build is failing on files I didn't touch for parts that don't interact with my changes 😕. Very confusing. Does anybody know why?