Clean user input for git clone extension#65906
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Aug 6, 2019
valtism:master
Merged
Clean user input for git clone extension#65906joaomoreno merged 1 commit intomicrosoft:masterfrom valtism:master
joaomoreno merged 1 commit intomicrosoft:masterfrom
valtism:master
Conversation
Strip whitespace and "git clone " from start of string. This will allow VSCode to intelligently handle copy and paste from command line instructions being pasted into the clone input box.
Member
|
Thanks! 🍻 Sorry for taking too long to get here. Part of this code was already in Related to #77878 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip whitespace and "git clone " from start of string. This will allow
VSCode to intelligently handle copy and paste from command line
instructions being pasted into the clone input box.
I've created this PR because there have been a few times I have just copy-pasted a git clone command into the clone box, and the failure message is not very intuitive as to what went wrong.
This is my first PR, so please let me know if anything is missing here, or if the code is not up to standard or could be harmful. I have tried to keep the scope of the input clean as minimal as possible for this reason.