fix(loc): fix incorrect phrasing for transparent color descriptions#66334
Merged
aeschli merged 1 commit intomicrosoft:masterfrom Jan 11, 2019
Merged
fix(loc): fix incorrect phrasing for transparent color descriptions#66334aeschli merged 1 commit intomicrosoft:masterfrom
aeschli merged 1 commit intomicrosoft:masterfrom
Conversation
The sentence 'The color must not be opaque to not hide underlying decorations' is incorrect. This PR replaces 'to not hide' with 'so as not to hide'. See the link below for why: https://english.stackexchange.com/questions/45265/use-of-so-as-not-to Closes microsoft#66333
|
I wouldn't say it's incorrect in this particular case (despite the SE link above--the example given there uses "not to" whereas here it's "to not" which clears up the ambiguity), but I will agree the current wording is very awkward so this is indeed an improvement. 👍 |
Contributor
Author
|
Yeah, I'm no linguist so maybe saying 'incorrect' is not... er... correct, but the current phrasing is awkward, especially the presence of two nots so close sent me on a trip deciphering what the text meant 😬 |
Contributor
|
Thanks @kumarharsh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sentence 'The color must not be opaque to not hide underlying
decorations' is incorrect. This PR replaces 'to not hide' with
'so as not to hide'. See the link below for why:
https://english.stackexchange.com/questions/45265/use-of-so-as-not-to
Closes #66333