Skip to content

Added strict null checks for findModel.test.ts#66706

Merged
alexdima merged 1 commit intomicrosoft:masterfrom
Pranshu258:addStrictNullChecks_FindModelTests
Feb 7, 2019
Merged

Added strict null checks for findModel.test.ts#66706
alexdima merged 1 commit intomicrosoft:masterfrom
Pranshu258:addStrictNullChecks_FindModelTests

Conversation

@Pranshu258
Copy link
Contributor

#65233

In this PR:

  • Fixed errors: "Object is possibly 'null'.", for tests in file "./vs/editor/contrib/find/test/findModel.test.ts"

@Pranshu258 Pranshu258 changed the title Added strict null checks for findModel.test.ts #65732 Added strict null checks for findModel.test.ts Jan 18, 2019
@Pranshu258
Copy link
Contributor Author

There are other errors on running the yarn strict-null-check command, all of them have the following message: Argument of type 'ICodeEditor' is not assignable to parameter of type 'IActiveCodeEditor'.

I am not sure how to fix that, therefore I have not added the file name to src/tsconfig.strictNullChecks.json. It would be great if someone could point me in the right direction to fix that. I will raise another PR for the fix.

@alexdima alexdima added this to the February 2019 milestone Feb 7, 2019
@alexdima alexdima merged commit ffa778a into microsoft:master Feb 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants