Setting longDescription as absolute#67077
Merged
isidorn merged 1 commit intomicrosoft:masterfrom Jan 28, 2019
Merged
Conversation
Collaborator
Contributor
Author
|
Pointers for change -
Thank you for looking through. |
Member
|
@isidorn this looks like the right change to me and what we currently have is a regression from how it used to be. If you look at https://github.com/Microsoft/vscode/blame/d901821f22e70f233e8ebe16f575647f05f4f537/src/vs/workbench/parts/files/common/editors/fileEditorInput.ts#L151 you can see that the long description is not the relative path. You can tell by looking at the context service not being passed in to the method which is used to produce a relative path. |
Collaborator
|
Fair enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.